Fix TestKit encoding where ByteBuffer.array may not exactly represent UTF8 encoded bytes
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testkit correction:
backing array ByteBuffer.array may not exactly represent UTF8 encoded bytes.
PR permit to ensure test is valid whatever the JVM is used
Example using jdk8:
"test-value".getBytes(StandardCharsets.UTF_8) => 0x746573742D76616C7565
StandardCharsets.UTF_8.encode("test-value").array() => 0x746573742D76616C756500 having an additional ending 0x00
Signed-off-by: diego Dupin <diego.dupin@gmail.com>
mp911de
changed the title
ByteBuffer.array may not exactly represent UTF8 encoded bytes
|
Thanks a lot for the fix. Going to merge it for 0.8, 0.9 and |
mp911de
pushed a commit
that referenced
this pull request
Feb 3, 2022
…sent UTF8 encoded bytes.
backing array ByteBuffer.array may not exactly represent UTF8 encoded bytes.
PR permit to ensure test is valid whatever the JVM is used
Example using jdk8:
"test-value".getBytes(StandardCharsets.UTF_8) => 0x746573742D76616C7565
StandardCharsets.UTF_8.encode("test-value").array() => 0x746573742D76616C756500 having an additional ending 0x00
Signed-off-by: diego Dupin <diego.dupin@gmail.com>
[resolves #264]
Signed-off-by: Mark Paluch <mpaluch@vmware.com>
mp911de
pushed a commit
that referenced
this pull request
Feb 3, 2022
…sent UTF8 encoded bytes.
backing array ByteBuffer.array may not exactly represent UTF8 encoded bytes.
PR permit to ensure test is valid whatever the JVM is used
Example using jdk8:
"test-value".getBytes(StandardCharsets.UTF_8) => 0x746573742D76616C7565
StandardCharsets.UTF_8.encode("test-value").array() => 0x746573742D76616C756500 having an additional ending 0x00
Signed-off-by: diego Dupin <diego.dupin@gmail.com>
[resolves #264]
Signed-off-by: Mark Paluch <mpaluch@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
Testkit correction:
backing array ByteBuffer.array may not exactly represent UTF8 encoded bytes.
PR permit to ensure test is valid whatever the JVM is used
Example using jdk8:
Signed-off-by: diego Dupindiego.dupin@gmail.com